Refactor internal parameter cleaning #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_params_* functions
… is_epidist_params
…parameter matching
…d dists with strict matching
joshwlambert
force-pushed
the
rm_internal_s3_dispatch
branch
from
97146ad
to
48167ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of S3 dispatch to call internal distribution parameter cleaning functions and moves to using
switch(). A bullet point is added to thedesign_principles.Rmdvignette on using S3 dispatch exclusively for exported functions.The internal
clean_epidist_params()is renamed with a dot prefix (.clean_epidist_params()). A bullet point is added to thedesign_principles.Rmdvignette on the use of dot prefixes for internal functions.The
.clean_epidist_params_*()distribution specific cleaning functions have been simplified thanks to having stricter parameter matching.Documentation and unit tests have been updated where needed.